Commit messages should be helpful to people reading your code in the future, so explain the reasoning for your decisions. A NACK needs to include a rationale why the change is not worthwhile. There are hundreds of open PRs, many require a lot of contextual knowledge, and contributors and reviewers often use unfamiliar terminology. For example, a pull request could add a feature, fix a bug, or refactor code; but not a mixture.
Using freenode
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software. The following channels can be found on Freenode. Iec channel hosts the weekly core dev meeting as bitcoin-core-pr-reviews freenode irc channel as the core dev wallet meeting every second week. Past and future topics can be found. If you have a topic you’d like to see discussed at the meeting, you can join the channel and propose it using proposedmeetingtopic. This channel is relatively new, and has mainly been discussing work on depends bitcoin-corr-pr-reviews GUIX build system integration.
Recent Meetings
Pull requests PRs are proposed changes to the codebase or documentation that can be submitted by anyone before being discussed by the maintainers and contributors of the project and eventually being either merged or closed. The aim of the review club is to onboard new contributors to Bitcoin Core by providing a stepping stone to reviewing and testing pull requests. IRC is a protocol that is as old as the web. It is the communication channel of choice for online Bitcoin technical meetings and conversations. Think of it like Slack or Mattermost but without the GIFs, emojis, threads and the ability to receive messages when offline. Indeed the company Slack emerged from attempting to address the shortcomings of IRC. IRC is also faster and less memory- and bandwidth-hungry.
All About Bitcoin Full Nodes (BTC, BCH, BSV)
About freenode
The title of the bitcoin-core-pr-rwviews request should be prefixed by the component or area that the pull request affects. The project coding conventions in the developer notes must be adhered to. Save and quit. Note that translations should not be submitted as pull requests, please see Translation Process for more information on helping with translations. Please refrain from creating several pull requests for the same change. At rreenode stage one should expect comments and review from other contributors. Final thought
Comments
Post a Comment