Skip to main content

Posts

Showing posts with the label ireland

Bitcoin-core-pr-reviews freenode irc channel

Commit messages should be helpful to people reading your code in the future, so explain the reasoning for your decisions. A NACK needs to include a rationale why the change is not worthwhile. There are hundreds of open PRs, many require a lot of contextual knowledge, and contributors and reviewers often use unfamiliar terminology. For example, a pull request could add a feature, fix a bug, or refactor code; but not a mixture.